Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing packages to consumer test #3737

Merged
merged 10 commits into from
Jun 22, 2021

Conversation

joshgummersall
Copy link
Contributor

@joshgummersall joshgummersall commented Jun 10, 2021

Fixes #3736

This also adds depcheck and replaces runtypes with zod for better compatibility with older versions of Typescript.

@joshgummersall joshgummersall requested review from stevengum and a team as code owners June 10, 2021 19:11
@joshgummersall joshgummersall force-pushed the jpg/reconcile-consumer-tests branch from 9e3bc2d to 7821fee Compare June 21, 2021 15:44
@joshgummersall joshgummersall requested a review from a team as a code owner June 21, 2021 15:44
@joshgummersall joshgummersall force-pushed the jpg/reconcile-consumer-tests branch from 7821fee to 4fde14c Compare June 21, 2021 15:47
@joshgummersall joshgummersall force-pushed the jpg/reconcile-consumer-tests branch 2 times, most recently from 0b09e2f to fdfe83d Compare June 21, 2021 16:03
@joshgummersall joshgummersall force-pushed the jpg/reconcile-consumer-tests branch from fdfe83d to a29832e Compare June 21, 2021 16:09
@coveralls
Copy link

coveralls commented Jun 21, 2021

Pull Request Test Coverage Report for Build 958908756

  • 19 of 29 (65.52%) changed or added relevant lines in 8 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 85.417%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-ai/src/luisRecognizerOptionsV3.ts 1 3 33.33%
libraries/botbuilder-azure-blobs/src/blobsStorage.ts 2 5 40.0%
libraries/botbuilder-azure-blobs/src/blobsTranscriptStore.ts 2 7 28.57%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-ai/src/luisRecognizerOptionsV3.ts 1 73.65%
Totals Coverage Status
Change from base Build 952706112: -0.001%
Covered Lines: 19301
Relevant Lines: 21496

💛 - Coveralls

@joshgummersall joshgummersall mentioned this pull request Jun 21, 2021
24 tasks
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some minor cleanup, LGTM!

@joshgummersall joshgummersall merged commit 542641d into main Jun 22, 2021
@joshgummersall joshgummersall deleted the jpg/reconcile-consumer-tests branch June 22, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add adaptive runtime packages to consumer tests
3 participants