feat: allow wildcard in mock paths #3713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdrichardson
commented
May 27, 2021
| path = path.startsWith('/') ? path : '/' + path; | ||
| if (path.includes('*')) { | ||
| // eslint-disable-next-line security/detect-non-literal-regexp |
There was a problem hiding this comment.
Note: This security check is for DoS attacks, which I don't believe is a concern, given how this is used in a test library for mocks.
mdrichardson
changed the title
Pull Request Test Coverage Report for Build 883257126
💛 - Coveralls |
joshgummersall
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3712
Description
See linked issue for more details, but this is for parity w/ .NET.
Specific Changes
Allow wildcards in URL paths by replacing the path with a RegExp and replacing
*with.*.Testing
Changed 1 test, which passes. Others will change as part of another PR.