Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: two typos #3696

Merged
merged 1 commit into from
May 18, 2021
Merged

fix: two typos #3696

merged 1 commit into from
May 18, 2021

Conversation

joshgummersall
Copy link
Contributor

#minor

@joshgummersall joshgummersall requested a review from a team as a code owner May 18, 2021 19:03
@joshgummersall joshgummersall mentioned this pull request May 18, 2021
Merged
@joshgummersall
Copy link
Contributor Author

Merging as ADO CI passed.

@joshgummersall joshgummersall merged commit ee4705c into main May 18, 2021
@joshgummersall joshgummersall deleted the jpg/fix-typo branch May 18, 2021 19:45
joshgummersall added a commit that referenced this pull request May 18, 2021
@joshgummersall
fix: two typos (#3696)
554ef25
joshgummersall added a commit that referenced this pull request May 18, 2021
@joshgummersall @stevengum
cherrypick: two more runtime fixes (#3695)
d2b0197 
* fix: more permissive type assertions (#3692)

* fix: more permissive type assertions

Fixes #3684

* fix: json serialization cycles (#3693)

See microsoft/BotFramework-Composer#7854 for more details.

* fix: limit serialized form of storage types

These can end up in serialized JSON transcripts as well, so to limit the chance of including connection strings or other
secrets we should restrict their serialized forms.

Co-authored-by: Steven Gum <[email protected]>

* fix: two typos (#3696)

Co-authored-by: Steven Gum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshgummersall @stevengum