Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: configure static directory, default wwwroot #3682

Merged
merged 1 commit into from
May 13, 2021
Merged

feat: configure static directory, default wwwroot #3682

merged 1 commit into from
May 13, 2021

Conversation

joshgummersall
Copy link
Contributor

Fixes #3681

@joshgummersall joshgummersall requested review from a team as code owners May 13, 2021 15:54
@joshgummersall joshgummersall requested review from chrimc62 and tomlm May 13, 2021 15:54
@joshgummersall joshgummersall mentioned this pull request May 13, 2021
Closed
8 tasks
@coveralls
Copy link

coveralls commented May 13, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 839494629

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 85.441%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
Totals Coverage Status
Change from base Build 837260458: -0.003%
Covered Lines: 19217
Relevant Lines: 21394
💛 - Coveralls

@joshgummersall joshgummersall force-pushed the jpg/static-directory-upgrade branch from ed0c7fc to c0eeeeb Compare May 13, 2021 16:25
@joshgummersall joshgummersall merged commit 0f1833f into main May 13, 2021
@joshgummersall joshgummersall deleted the jpg/static-directory-upgrade branch May 13, 2021 16:48
joshgummersall added a commit that referenced this pull request May 13, 2021
@joshgummersall
feat: configure static directory, default wwwroot (#3682)
d009755 
Fixes #3681
joshgummersall added a commit that referenced this pull request May 13, 2021
@joshgummersall
feat: configure static directory, default wwwroot (#3682) (#3683)
199aba1 
Fixes #3681
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdrichardson mdrichardson mdrichardson left review comments

@peterinnesmsft peterinnesmsft peterinnesmsft approved these changes

@chrimc62 chrimc62 Awaiting requested review from chrimc62

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default static directory to wwwroot instead of public
4 participants
@joshgummersall @coveralls @mdrichardson @peterinnesmsft