port: Support object comparison in == #3672
Conversation
Danieladu
requested review from
joshgummersall,
stevengum and
a team
as code owners
Pull Request Test Coverage Report for Build 851669384
💛 - Coveralls |
| found = args[0].includes(args[1]); | ||
| } else if (args[0] instanceof Map) { |
There was a problem hiding this comment.
Does it seem like this logic is getting lost in this refactor?
There was a problem hiding this comment.
Yes. The logic of contains of Map would be handlered in accessProperty
| */ | ||
| private static convertToObj(instance: unknown) { | ||
| if (FunctionUtils.getPropertyCount(instance) >= 0) { | ||
| if (instance instanceof Map) { |
There was a problem hiding this comment.
Last suggestion, then I promise I won't code-golf anymore on this PR 😄
const entries = instance instanceof Map ? instance.entries() : Object.entries(instance);
return entries.reduce((acc, [key, value]) => ({...acc, [key]: FunctionUtils.convertToObj(value)}), {});There was a problem hiding this comment.
More suggestions better! Means more can learn.
reduce could not apply on IterableIterator directly. So I use Array.from(instance.entries()) to convert it into Array.
|
The browserBot is always failing. But I could not access the details of the error message. @joshgummersall Could you help to take a look and whether some APIs are unavailable. |
|
@Danieladu yep I discovered that myself today! I'll land this and try to resolve it tomorrow. |
Fixes #3671
Description
Support object comparison in
==Specific Changes
contains==and!=