chore: Replace catch with assert.rejects|throws in tests (part 3 of 3)

[mdrichardson]

Fixes: #3426

Note: This is part 3 of 3, so the issue is done after this merges. There's some tests that weren't converted, for various reasons, detailed in each PR.

#minor

Description

We has some awkward usage of

try {
  methodThatShouldFail()
  assert.fail('not whatever')
} catch (err) {
	assert.strictEqual(err.message, 'whatever');
}

That I converted to

assert.throws(
	() => methodThatShouldFail(),
	Error('whatever')
);

Note

There's a commit with a bunch of no-op linting fixes. I recommend mostly reviewing the other one. However, I accidentally committed some no-op changes to skillDialog.test.js. sorry.

I skipped a LOT of tests in botframework-streaming because:

1. They rely on chai, which doesn't handle rejects() without chai-as-promised
2. The nature of the promises in this library don't work well with rejects() and are handled better/easier with the existing try/catch

[coveralls]

Pull Request Test Coverage Report for Build 821233558

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.9%) to 85.441%

---

Totals
Change from base Build 820648573:	0.9%
Covered Lines:	19217
Relevant Lines:	21394

---

💛 - Coveralls