Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cleanup lint errors in bf-connector #3646

Merged
merged 1 commit into from
May 3, 2021
Merged

fix: cleanup lint errors in bf-connector #3646

merged 1 commit into from
May 3, 2021

Conversation

stevengum
Copy link
Member

#minor

Description

Addresses lint errors in botframework-connector, the new doc strings are either a verbatim port from .NET or derived from examples in the JS SDK.

@stevengum stevengum requested a review from joshgummersall May 3, 2021 21:16
@stevengum stevengum requested a review from a team as a code owner May 3, 2021 21:16
@coveralls
Copy link

coveralls commented May 3, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 808121573

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.0009%) to 85.434%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-connector/src/auth/certificateAppCredentials.ts 1 31.25%
Totals Coverage Status
Change from base Build 807648684: -0.0009%
Covered Lines: 19217
Relevant Lines: 21393
💛 - Coveralls

@stevengum stevengum merged commit 754c39e into main May 3, 2021
@stevengum stevengum deleted the stgum/linting branch May 3, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevengum @coveralls @joshgummersall