Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: merge generated config into runtime config #3561

Merged
merged 2 commits into from
Apr 12, 2021
Merged

fix: merge generated config into runtime config #3561

merged 2 commits into from
Apr 12, 2021

Conversation

joshgummersall
Copy link
Contributor

Fixes #3558

@joshgummersall joshgummersall requested review from a team as code owners April 12, 2021 20:28
@joshgummersall
Copy link
Contributor Author

This maps to https://github.com/microsoft/botbuilder-dotnet/blob/main/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive.Runtime/Extensions/ConfigurationBuilderExtensions.cs#L107 which was omitted initially.

@joshgummersall joshgummersall requested a review from benbrown April 12, 2021 20:29
@coveralls
Copy link

coveralls commented Apr 12, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 742595882

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 84.943%
Totals Coverage Status
Change from base Build 734412837: -0.006%
Covered Lines: 18973
Relevant Lines: 21277
💛 - Coveralls

@joshgummersall joshgummersall force-pushed the jpg/runtime-composer-configuration branch from 56091dc to 30b3c32 Compare April 12, 2021 20:45
stevengum
stevengum reviewed Apr 12, 2021
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, and can you add a test for this change?

@joshgummersall
Copy link
Contributor Author

@stevengum added

stevengum
stevengum approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@stevengum stevengum merged commit 5326335 into main Apr 12, 2021
@stevengum stevengum deleted the jpg/runtime-composer-configuration branch April 12, 2021 23:12
joshgummersall added a commit that referenced this pull request Apr 12, 2021
@joshgummersall
fix: merge generated config into runtime config (#3561)
0094cea 
* fix: merge generated config into runtime config

Fixes #3558

* fix: pr comments
joshgummersall added a commit that referenced this pull request Apr 13, 2021
@joshgummersall
fix: merge generated config into runtime config (#3561) (#3563)
738be25 
* fix: merge generated config into runtime config

Fixes #3558

* fix: pr comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@EricDahlvang EricDahlvang Awaiting requested review from EricDahlvang

@luhan2017 luhan2017 Awaiting requested review from luhan2017

@benbrown benbrown Awaiting requested review from benbrown

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: JS runtime has issue with luis application ID
3 participants
@joshgummersall @coveralls @stevengum