Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: async error handling for request handlers #3492

Merged
merged 1 commit into from
Mar 30, 2021
Merged

fix: async error handling for request handlers #3492

merged 1 commit into from
Mar 30, 2021

Conversation

joshgummersall
Copy link
Contributor

@joshgummersall joshgummersall commented Mar 30, 2021 •
edited
Loading

Adds proper error handling to integration servers.

Fixes #3493

@joshgummersall joshgummersall requested review from a team as code owners March 30, 2021 20:31
stevengum
stevengum approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant and straightforward, nice!

@coveralls
Copy link

coveralls commented Mar 30, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 702750459

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 84.895%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 2 61.63%
libraries/adaptive-expressions/src/triggerTrees/node.ts 8 91.7%
Totals Coverage Status
Change from base Build 702218752: -0.05%
Covered Lines: 18888
Relevant Lines: 21184
💛 - Coveralls

@joshgummersall joshgummersall merged commit 2032b4b into main Mar 30, 2021
@joshgummersall joshgummersall deleted the jpg/integration-async-handlers branch March 30, 2021 20:49
joshgummersall added a commit that referenced this pull request Mar 30, 2021
@joshgummersall
fix: async error handling for request handlers (#3492)
35e7556
@joshgummersall joshgummersall mentioned this pull request Mar 30, 2021
Closed
joshgummersall added a commit that referenced this pull request Mar 30, 2021
@joshgummersall
fix: async error handling for request handlers (#3492)
559e7fc
joshgummersall added a commit that referenced this pull request Mar 30, 2021
@joshgummersall
fix: async error handling for request handlers (#3492) (#3495)
88319c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

integrations do not handle errors
3 participants
@joshgummersall @coveralls @stevengum