Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: Support null for built-in function empty #3484

Merged
merged 3 commits into from
Mar 30, 2021
Merged

port: Support null for built-in function empty #3484

merged 3 commits into from
Mar 30, 2021

Conversation

Danieladu
Copy link
Contributor

Fixes #3483

Description

The doc of empty shows that if the input is null, true would be given.

Example:

empty(null)   -> true
empty(undefined)   -> true

@Danieladu Danieladu requested review from a team as code owners March 30, 2021 03:52
@Danieladu Danieladu requested review from Stevenic and luhan2017 March 30, 2021 03:52
@coveralls
Copy link

coveralls commented Mar 30, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 701911213

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 84.956%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/functionUtils.ts 11 90.29%
Totals Coverage Status
Change from base Build 700686686: 0.01%
Covered Lines: 18900
Relevant Lines: 21184
💛 - Coveralls

@joshgummersall joshgummersall merged commit 6af066f into main Mar 30, 2021
@joshgummersall joshgummersall deleted the hond/empty branch March 30, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: Support null for buildin function empty (#5338)
3 participants
@Danieladu @coveralls @joshgummersall