Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove HealthCheck code for #3374 #3482

Merged
merged 3 commits into from
Mar 30, 2021
Merged

fix: remove HealthCheck code for #3374 #3482

merged 3 commits into from
Mar 30, 2021

Conversation

stevengum
Copy link
Member

Fixes #3374

Description

Port of microsoft/botbuilder-dotnet#5352, which removes the HealthCheck code and tests from the code base.

@stevengum stevengum requested a review from a team as a code owner March 29, 2021 23:18
@coveralls
Copy link

coveralls commented Mar 29, 2021

Pull Request Test Coverage Report for Build 699616248

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 64 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.06%) to 84.937%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
libraries/botbuilder-core/src/activityHandler.ts 14 78.67%
libraries/botframework-schema/src/index.ts 15 65.02%
libraries/botbuilder/src/botFrameworkAdapter.ts 34 89.69%
Totals Coverage Status
Change from base Build 699615964: 0.06%
Covered Lines: 18878
Relevant Lines: 21164

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate HealthCheck activity (JS)
3 participants