Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: Add support of Expressions in BeginDialog Actions #3460

Merged
merged 9 commits into from
Mar 30, 2021

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Mar 26, 2021

Fixes #3418

Description

Add support of Expressions in BeginDialog Actions.

Specific Changes

  • Implemented DialogSetConverter

Testing

Ported tests.

@chon219 chon219 requested review from chrimc62, tomlm and a team as code owners March 26, 2021 03:14
@coveralls
Copy link

coveralls commented Mar 26, 2021

Pull Request Test Coverage Report for Build 700063823

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 174 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 84.943%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-dialogs-adaptive/src/adaptiveDialog.ts 174 38.3%
Totals Coverage Status
Change from base Build 699656075: 0.05%
Covered Lines: 18895
Relevant Lines: 21181

💛 - Coveralls

@chon219
Copy link
Member Author

chon219 commented Mar 29, 2021

It is so weird that tests will fail on Windows for 'bf' is not recognized as an internal or external command, operable program or batch file., do you know why? @joshgummersall

@joshgummersall joshgummersall force-pushed the zim/begin-dialog-expression branch from a6a42ea to fea5c3b Compare March 29, 2021 16:09
@joshgummersall
Copy link
Contributor

@chon219 in order to get the tests to pass, run yarn test:schema locally and commit the changes to the test schema file.

@chon219
Copy link
Member Author

chon219 commented Mar 30, 2021

@chon219 Zichuan Ma FTE in order to get the tests to pass, run yarn test:schema locally and commit the changes to the test schema file.

Got it, thanks.

@chon219 chon219 merged commit 02423c0 into main Mar 30, 2021
@chon219 chon219 deleted the zim/begin-dialog-expression branch March 30, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: Add support of Expressions in BeginDialog Actions (#4880)
4 participants