Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: refactor plugin interface to BotComponent class #3454

Merged
merged 3 commits into from
Mar 26, 2021

Conversation

joshgummersall
Copy link
Contributor

Step one of #3453

The unfortunate downside here is that we no longer have a "global" registry of keys and types. This will have to suffice in order to move forward on deprecating ComponentRegistrations in favor of BotComponents. Producing the registry would result in dependency cycles. We can perhaps revisit making this more type-safe in a future revision.

@joshgummersall joshgummersall requested review from stevengum and a team as code owners March 25, 2021 20:47
@joshgummersall joshgummersall force-pushed the jpg/runtime-service-collection-refactor branch 2 times, most recently from beffcb0 to 4cf7bab Compare March 25, 2021 20:55
@stevengum stevengum self-assigned this Mar 25, 2021
@coveralls
Copy link

coveralls commented Mar 25, 2021

Pull Request Test Coverage Report for Build 691490361

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 84.947%

Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 2 61.63%
libraries/adaptive-expressions/src/triggerTrees/node.ts 8 91.7%
Totals Coverage Status
Change from base Build 691469957: -0.06%
Covered Lines: 18906
Relevant Lines: 21185

💛 - Coveralls

@joshgummersall joshgummersall force-pushed the jpg/runtime-service-collection-refactor branch from 69b9e51 to 19e086e Compare March 26, 2021 20:04
@joshgummersall joshgummersall requested review from a team as code owners March 26, 2021 20:04
@joshgummersall joshgummersall force-pushed the jpg/runtime-service-collection-refactor branch 2 times, most recently from a49837a to e8c3579 Compare March 26, 2021 22:13
@joshgummersall joshgummersall force-pushed the jpg/runtime-service-collection-refactor branch from e8c3579 to f3c4a77 Compare March 26, 2021 22:50
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@joshgummersall joshgummersall merged commit 35f2f10 into main Mar 26, 2021
@joshgummersall joshgummersall deleted the jpg/runtime-service-collection-refactor branch March 26, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants