Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make useNamedPipe idempotent if already connected to pipeName #3450

Merged
merged 3 commits into from
Mar 25, 2021

Conversation

stevengum
Copy link
Member

Fixes #3449

Specific Changes

  • Make BotFrameworkAdapter.useNamedPipe idempotent by checking for StreamingServer and new namedPipeName member
  • Add private namedPipeName?: string member to BotFrameworkAdapter
  • Minor docstring fix in botframework-streaming.NamedPipeServer

Testing

Add new tests for new behavior in useNamedPipe

@stevengum stevengum requested review from a team as code owners March 25, 2021 18:30
@coveralls
Copy link

coveralls commented Mar 25, 2021

Pull Request Test Coverage Report for Build 687760863

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 47 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.03%) to 84.984%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 2 61.92%
libraries/adaptive-expressions/src/triggerTrees/node.ts 8 91.7%
libraries/botbuilder/src/botFrameworkAdapter.ts 36 89.09%
Totals Coverage Status
Change from base Build 687729579: -0.03%
Covered Lines: 18816
Relevant Lines: 21083

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants