-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port several runtime changes #3446
Conversation
This ports the ConfigurationResourceProvider from .NET. In addition, it makes some changes to Configuration handling throughout the runtime. The .NET configuration interface is not async, so let's match that. In particular, anything that operates on a Configuration instance can, itself, resolve any async operations before or after mutations. This will provide better interop with existing Adaptive classes, the prime example being the Resource Explorer. Unfortunately, most of that code was written in a way that is not terribly async friendly. It's easier to push async operations outside the Configuration interface, so that's what we do.
Pull Request Test Coverage Report for Build 687579641
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had one bit of feedback around the new static members, but otherwise it looks good. Thanks for adding the comment around the async-to-sync changes in the PR:
This ports the ConfigurationResourceProvider from .NET. In addition, it makes some changes to Configuration handling
throughout the runtime.The .NET configuration interface is not async, so let's match that. In particular, anything that operates on a
Configuration instance can, itself, resolve any async operations before or after mutations.This will provide better interop with existing Adaptive classes, the prime example being the Resource Explorer.
Unfortunately, most of that code was written in a way that is not terribly async friendly. It's easier to push async
operations outside the Configuration interface, so that's what we do.
via commit 79782de
00b944d
to
ebd1741
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ConfigurationResourceProvider
, which is part of Port Adaptive Dialog Bot #3423