Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: Check null for input prompt #3425

Merged
merged 3 commits into from
Mar 23, 2021
Merged

port: Check null for input prompt #3425

merged 3 commits into from
Mar 23, 2021

Conversation

Danieladu
Copy link
Contributor

Fixes #3424

@Danieladu Danieladu requested review from a team as code owners March 23, 2021 02:15
@Danieladu Danieladu requested review from chrimc62 and tomlm March 23, 2021 02:15
@coveralls
Copy link

coveralls commented Mar 23, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 678207756

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 85.157%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 4 61.63%
Totals Coverage Status
Change from base Build 677526557: 0.004%
Covered Lines: 18776
Relevant Lines: 21007
💛 - Coveralls

@joshgummersall joshgummersall merged commit 59a276f into main Mar 23, 2021
@joshgummersall joshgummersall deleted the hond/checknull branch March 23, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@chrimc62 chrimc62 Awaiting requested review from chrimc62

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: Check null for input prompt (#5322)
3 participants
@Danieladu @coveralls @joshgummersall