-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace done w/ async part 3 #3422
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdrichardson
commented
Mar 23, 2021
Pull Request Test Coverage Report for Build 680668252
💛 - Coveralls |
mdrichardson
commented
Mar 23, 2021
joshgummersall
approved these changes
Mar 23, 2021
stevengum
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #3226. This will be done in multiple PRs.
Covers
(Alphabetically such that
botbuilder
comes beforebotbuilder-
)botbuilder-azure
throughbotbuilder-core
, inclusiveExcludes
blobStorage.test.js
cosmosDbStorage.test.js
Description
Replaces the use of
done()
in tests with properasync/await
.Specific Changes
done
=>async/await
done(err)
Notes (mostly for me)
(done =>)|\(done\)
./libraries/**/**/tests/**/*.js
await
toadapter.send()
calls:(?<!(await)|(const))\sadapter