Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace done w/ async part 3 #3422

Merged
merged 8 commits into from
Mar 24, 2021

Conversation

mdrichardson
Copy link
Contributor

Partial fix for #3226. This will be done in multiple PRs.

Covers

(Alphabetically such that botbuilder comes before botbuilder-)

  • botbuilder-azure through botbuilder-core, inclusive

Excludes

  • blobStorage.test.js
  • cosmosDbStorage.test.js

Description

Replaces the use of done() in tests with proper async/await.

Specific Changes

  • done => async/await
  • Remove some of the try/catches that are no longer needed since we don't need done(err)
  • Avoid arrow function in mocha tests
  • A lot of no-op stuff auto-fixes with our prettier/eslint settings

Notes (mostly for me)

  • Regex for finding done usage: (done =>)|\(done\)
  • Search in: ./libraries/**/**/tests/**/*.js
  • For adding await to adapter.send() calls: (?<!(await)|(const))\sadapter

@coveralls
Copy link

coveralls commented Mar 23, 2021

Pull Request Test Coverage Report for Build 680668252

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 85.153%

Totals Coverage Status
Change from base Build 680203276: 0.03%
Covered Lines: 18804
Relevant Lines: 21033

💛 - Coveralls

@mdrichardson mdrichardson marked this pull request as ready for review March 23, 2021 19:49
@mdrichardson mdrichardson requested a review from a team as a code owner March 23, 2021 19:49
@joshgummersall joshgummersall merged commit 7f3694f into microsoft:main Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants