Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: do nothing when activity is null #3421

Merged
merged 2 commits into from
Mar 24, 2021
Merged

port: do nothing when activity is null #3421

merged 2 commits into from
Mar 24, 2021

Conversation

joshgummersall
Copy link
Contributor

Fixes #3417

@joshgummersall joshgummersall requested review from a team as code owners March 22, 2021 22:47
@coveralls
Copy link

coveralls commented Mar 22, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 684145518

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 85.03%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-dialogs-adaptive/src/input/inputDialog.ts 13 87.96%
Totals Coverage Status
Change from base Build 684135609: 0.001%
Covered Lines: 18786
Relevant Lines: 21040
💛 - Coveralls

@joshgummersall joshgummersall force-pushed the jpg/port-do-nothing-activity-null branch 3 times, most recently from 2ffe8f2 to 0e15674 Compare March 24, 2021 17:21
@joshgummersall joshgummersall force-pushed the jpg/port-do-nothing-activity-null branch from 0e15674 to 7fb3c15 Compare March 24, 2021 18:27
@joshgummersall joshgummersall merged commit c18d387 into main Mar 24, 2021
@joshgummersall joshgummersall deleted the jpg/port-do-nothing-activity-null branch March 24, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@chrimc62 chrimc62 Awaiting requested review from chrimc62

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: Do nothing when the activity is null (#5320)
3 participants
@joshgummersall @coveralls @stevengum