Replace done w/ async in tests part 1 #3413
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #3226. This will be done in multiple PRs.
Covers
(Alphabetically such that
botbuilder
comes beforebotbuilder-
)adaptive-expressions-ie11
throughbotbuilder
, inclusiveExcludes
channelServiceRoutes.test.js
Description
Replaces the use of
done()
in tests with properasync/await
.Specific Changes
done
=>async/await
done
completely when used in synchronous tests. For example, it was in somebeforeEach()
hooks, but it's not needed; nock doesn't even use it theredone(err)
Notes (mostly for me)
(done =>)|\(done\)
./libraries/**/**/tests/**/*.js
await
toadapter.send()
calls:(?<!(await)|(const))\sadapter