Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: enable LG syntax in OAuthInput #3409

Merged
merged 11 commits into from
Mar 22, 2021
Merged

port: enable LG syntax in OAuthInput #3409

merged 11 commits into from
Mar 22, 2021

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Mar 18, 2021

Fixes #3306

Description

Enabled LG syntax in OAuthInput's title and text.
Fixed blocking bugs as well.

Specific Changes

  • Refactored OAuthPrompt to expose sendOAuthCard()
  • Updated OAuthInput to enable LG syntax
  • Fixed a blocking bug in Expression.parse() to trim starting = of expressions
  • Fixed a blocking bug in Templates to recognize multi line text correctly

Testing

Ported tests as well.

@chon219 chon219 requested review from a team as code owners March 18, 2021 06:31
@chon219 chon219 requested a review from Stevenic March 18, 2021 06:31
@coveralls
Copy link

coveralls commented Mar 18, 2021

Pull Request Test Coverage Report for Build 677436629

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 80 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.07%) to 85.158%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templates.ts 3 93.85%
libraries/botbuilder-dialogs/src/prompts/oauthPrompt.ts 24 75.79%
libraries/botbuilder-dialogs-adaptive/src/input/oauthInput.ts 53 57.19%
Totals Coverage Status
Change from base Build 677427736: 0.07%
Covered Lines: 18770
Relevant Lines: 21000

💛 - Coveralls

Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small ask, otherwise looks good.

@joshgummersall joshgummersall merged commit e09dc68 into main Mar 22, 2021
@joshgummersall joshgummersall deleted the zim/oauth-input-lg branch March 22, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: Enable LG syntax in OAuthInput Text and Title (#5186)
3 participants