Add dialog:merge tests #3404
Merged
Add dialog:merge tests #3404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdrichardson
requested review from
chrimc62,
joshgummersall,
stevengum,
tomlm and
a team
as code owners
Closed
Pull Request Test Coverage Report for Build 662101311
💛 - Coveralls |
libraries/botbuilder-dialogs-declarative/tests/schemaMergeTest.js
Outdated
Show resolved
Hide resolved
|
Converting to draft while I add in this: #3405 |
| // command was run. We only test for this in CI because these files are expected to differ | ||
| // when this test is run locally. | ||
| const newSchema = fs.existsSync(testsSchemaPath) && JSON.parse(testsSchemaFileResource.readText()); | ||
| assert( |
There was a problem hiding this comment.
assert.deepStrictEqual may be a good option? It should produce and output a diff that is human readable.
joshgummersall
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces: #3399
Fixes #2636
Fixes #3405
Description
Ported over .NET's/BF-CLI's
dialog:mergetests and added to CI workflow (only on the Node v10.x run).