Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: Make syntax error message more readable in Expression #3387

Merged
merged 1 commit into from
Mar 11, 2021
Merged

port: Make syntax error message more readable in Expression #3387

merged 1 commit into from
Mar 11, 2021

Conversation

Danieladu
Copy link
Contributor

Fixes #3368

Description

The error thrown by Antlr is not readable for non-developer users. Change it to the general expression format error.

@Danieladu Danieladu requested review from a team as code owners March 11, 2021 02:21
@Danieladu Danieladu requested review from tomlm and luhan2017 March 11, 2021 02:22
@coveralls
Copy link

coveralls commented Mar 11, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 641369465

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 85.095%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 2 63.08%
Totals Coverage Status
Change from base Build 640045250: 0.004%
Covered Lines: 18750
Relevant Lines: 20990
💛 - Coveralls

@Danieladu Danieladu changed the title [PORT] Make syntax error message more readable in Expression port: Make syntax error message more readable in Expression Mar 11, 2021
@joshgummersall joshgummersall merged commit 59d7f11 into main Mar 11, 2021
@joshgummersall joshgummersall deleted the hond/error branch March 11, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@tomlm tomlm Awaiting requested review from tomlm

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: Make syntax error message more readable in Expression (#5275)
3 participants
@Danieladu @coveralls @joshgummersall