Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dialogs component registration #3380

Merged
merged 12 commits into from
Mar 12, 2021

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Mar 9, 2021

Description

Added dialogs component registration to provide memory scopes and path resolvers.

Specific Changes

  • Added interface ComponentMemoryScopes
  • Added interface ComponentPathResolvers
  • Moved default memory scopes and path resolvers to DialogsComponentRegistration

Testing

Updated related tests.

@chon219 chon219 requested review from a team as code owners March 9, 2021 07:36
@coveralls
Copy link

coveralls commented Mar 9, 2021

Pull Request Test Coverage Report for Build 644597079

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 85.118%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-dialogs/src/memory/dialogStateManager.ts 4 95.37%
Totals Coverage Status
Change from base Build 643559629: 0.08%
Covered Lines: 18776
Relevant Lines: 21014

💛 - Coveralls

Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two quick suggestions, otherwise look good!

@joshgummersall joshgummersall merged commit 08c0e54 into main Mar 12, 2021
@joshgummersall joshgummersall deleted the zim/dialogs-component-registration branch March 12, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants