Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add startTest() to all TestFlows #3379

Merged
merged 4 commits into from
Mar 9, 2021

Conversation

mdrichardson
Copy link
Contributor

@mdrichardson mdrichardson commented Mar 9, 2021

Fixes #3231

Description

Mostly no-op, but makes debugging a little easier. See linked issue for more info.

Note that for tests that rely on done() this won't do much until the tests are converted to using async/await. There's some tests where a then(done) exists in the chain and it didn't seem to matter whether startTest() was added before or after it. It will be irrelevant, anyway, when I convert them to async tests in #3226

Specific Changes

  • Append startTest() to the end of all TestFlows

Testing

I edited a few flows to make them fail to confirm they all still work appropriately.

@mdrichardson mdrichardson requested review from a team as code owners March 9, 2021 00:58
@mdrichardson mdrichardson changed the title Add startTest() to all test flows Add startTest() to all TestFlows Mar 9, 2021
@coveralls
Copy link

coveralls commented Mar 9, 2021

Pull Request Test Coverage Report for Build 636623662

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 84.838%

Totals Coverage Status
Change from base Build 636450762: 0.003%
Covered Lines: 18654
Relevant Lines: 20940

💛 - Coveralls

@joshgummersall joshgummersall merged commit 2ee1beb into microsoft:main Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add startTest() to awaited adapter.send() tests
3 participants