-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: botframework http adapter #3375
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e695771
to
072ed64
Compare
Pull Request Test Coverage Report for Build 677430326
💛 - Coveralls |
072ed64
to
8ce88d4
Compare
stevengum
requested changes
Mar 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comments I'd like to see addressed are the BotFrameworkHttpAdapter typo and the ActivityTypes.Delay.
libraries/botframework-connector/src/connectorApi/operations/conversations.ts
Show resolved
Hide resolved
8ce88d4
to
8ce4233
Compare
8ce4233
to
4dc7730
Compare
f89c87b
to
ef51544
Compare
4dc7730
to
56efb81
Compare
stevengum
approved these changes
Mar 18, 2021
18146eb
to
0a4a113
Compare
- Add ActivityTypes.Delay consolidate sinon versions in root package
0a4a113
to
d390adf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3420
Also includes:
delay
functionPartial<Activity>
instead of obfuscatedas Activity
invocation pattern