Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: botframework http adapter #3375

Merged
merged 5 commits into from
Mar 22, 2021
Merged

Conversation

joshgummersall
Copy link
Contributor

@joshgummersall joshgummersall commented Mar 8, 2021

Fixes #3420

Also includes:

  • standard lib delay function
  • consolidated sinon versions
  • fix API calls to accept Partial<Activity> instead of obfuscated as Activity invocation pattern

@joshgummersall joshgummersall requested review from stevengum and a team as code owners March 8, 2021 21:27
@joshgummersall joshgummersall force-pushed the jpg/botframework-http-adapter branch from e695771 to 072ed64 Compare March 8, 2021 21:32
@coveralls
Copy link

coveralls commented Mar 8, 2021

Pull Request Test Coverage Report for Build 677430326

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 35 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.006%) to 85.084%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
libraries/botbuilder/src/botFrameworkAdapter.ts 34 88.82%
Totals Coverage Status
Change from base Build 677427736: -0.006%
Covered Lines: 18790
Relevant Lines: 21037

💛 - Coveralls

@joshgummersall joshgummersall force-pushed the jpg/botframework-http-adapter branch from 072ed64 to 8ce88d4 Compare March 10, 2021 17:09
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments I'd like to see addressed are the BotFrameworkHttpAdapter typo and the ActivityTypes.Delay.

@joshgummersall joshgummersall force-pushed the jpg/botframework-http-adapter branch from 8ce88d4 to 8ce4233 Compare March 11, 2021 19:02
@joshgummersall joshgummersall changed the base branch from main to jpg/streaming-test-cleanup March 11, 2021 19:04
@joshgummersall joshgummersall force-pushed the jpg/botframework-http-adapter branch from 8ce4233 to 4dc7730 Compare March 11, 2021 21:50
@joshgummersall joshgummersall force-pushed the jpg/streaming-test-cleanup branch 5 times, most recently from f89c87b to ef51544 Compare March 18, 2021 03:34
@joshgummersall joshgummersall force-pushed the jpg/botframework-http-adapter branch from 4dc7730 to 56efb81 Compare March 18, 2021 18:18
@joshgummersall joshgummersall changed the base branch from jpg/streaming-test-cleanup to main March 18, 2021 18:18
@joshgummersall joshgummersall force-pushed the jpg/botframework-http-adapter branch from 18146eb to 0a4a113 Compare March 22, 2021 17:01
@joshgummersall joshgummersall force-pushed the jpg/botframework-http-adapter branch from 0a4a113 to d390adf Compare March 22, 2021 20:49
@joshgummersall joshgummersall merged commit 728ed17 into main Mar 22, 2021
@joshgummersall joshgummersall deleted the jpg/botframework-http-adapter branch March 22, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add BotFrameworkHttpAdapter
3 participants