New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: language generation component registration #3370

Merged

chon219 merged 2 commits into main from zim/language-generation-component

Mar 9, 2021

Member

chon219 commented Mar 8, 2021 •

edited

Loading

Description

Wrap TemplateInterface based classes into LanguageGenerationComponentRegistration to match the implementation in C#: https://github.com/microsoft/botbuilder-dotnet/blob/main/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/LanguageGenerationComponentRegistration.cs

Specific Changes

LanguageGenerationComponentRegistration

Testing

Updated related tests.

chon219 added 2 commits

March 8, 2021 14:59


          added language generation component registration

59087ae


          updated tests

86e8835

chon219 added the Area: Adaptive label

chon219 requested review from joshgummersall and cosmicshuai

March 8, 2021 07:03

chon219 requested review from a team as code owners

March 8, 2021 07:03

chon219 requested a review from luhan2017

March 8, 2021 07:03

coveralls commented Mar 8, 2021 •

edited

Loading

Pull Request Test Coverage Report for Build 631442918

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 84.894%

Totals
Change from base Build 625889807:	0.05%
Covered Lines:	18647
Relevant Lines:	20924

💛 - Coveralls

joshgummersall approved these changes

View reviewed changes

chon219 merged commit c28ab7f into main

chon219 deleted the zim/language-generation-component branch

March 9, 2021 02:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels