Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port: Switch priority in triggers to float type #3362

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Port: Switch priority in triggers to float type #3362

merged 1 commit into from
Mar 5, 2021

Conversation

cosmicshuai
Copy link
Contributor

closes: #3349
Now the priority in triggers is float number, where 0 is the highest and less than 0 is ignored.

The priority property in OnCondition now is NumberExpression, the default value is 0.

@cosmicshuai cosmicshuai requested review from chrimc62, tomlm and a team as code owners March 5, 2021 09:34
@coveralls
Copy link

coveralls commented Mar 5, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 623981754

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 84.901%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 2 61.63%
Totals Coverage Status
Change from base Build 623512400: -0.006%
Covered Lines: 18634
Relevant Lines: 20913
💛 - Coveralls

@joshgummersall joshgummersall merged commit bbad733 into main Mar 5, 2021
@joshgummersall joshgummersall deleted the shuwan/portFloatPriority branch March 5, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@chrimc62 chrimc62 Awaiting requested review from chrimc62

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: Switch priority in triggers to float type (#5259)
3 participants
@cosmicshuai @coveralls @joshgummersall