-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch premature dialog endings #3361
Merged
stevengum
merged 5 commits into
microsoft:main
from
mdrichardson:dialogHelperCompletions
Mar 5, 2021
Merged
Catch premature dialog endings #3361
stevengum
merged 5 commits into
microsoft:main
from
mdrichardson:dialogHelperCompletions
Mar 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 625821802
💛 - Coveralls |
stevengum
requested changes
Mar 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes and cleanup requested, otherwise it looks great! Thanks for the quick turnaround 👍🏼
stevengum
approved these changes
Mar 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3355
Description
runDialog()
works great for dialogs that take more than one turn to complete, but it fails otherwise. A single-step or immediately-cancelled dialog should be pretty rare, but this should fix things for them.The general flow for the way things work currently:
bot.js
file callsrunDialog()
(usually inonTurn()
oronMessage()
runDialog
setsresult
tocontinueDialog()
result
will beDialogTurnStatus.Empty
, sorunDialog
then callsbeginDialog()
.runDialog()
is called again, socontinueDialog()
is called again.beginDialog()
--the dialog is cancelled or ended before the turn ends,result
remainsDialogTurnStatus.Empty
(instead of getting updated toCompleted
orCancelled
), so EoC is never sent back to the parentSpecific Changes
Allow
result
to be updated with thebeginDialog()
call.Testing
Tested using the bots in the linked issue and it worked.