Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include conversation ID in telemetry events #3347

Merged
merged 3 commits into from
Mar 5, 2021
Merged

fix: include conversation ID in telemetry events #3347

merged 3 commits into from
Mar 5, 2021

Conversation

joshgummersall
Copy link
Contributor

Fixes #3343

@joshgummersall joshgummersall requested review from stevengum and a team as code owners March 1, 2021 20:38
@coveralls
Copy link

coveralls commented Mar 1, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 625550554

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 84.888%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-core/src/telemetryLoggerMiddleware.ts 8 79.4%
Totals Coverage Status
Change from base Build 625219772: -0.04%
Covered Lines: 18647
Relevant Lines: 20924
💛 - Coveralls

stevengum
stevengum approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@stevengum stevengum merged commit 95e48f2 into main Mar 5, 2021
@stevengum stevengum deleted the jpg/fix-telemetry-properties branch March 5, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conversation ID is not attached to most Telemetry Events in telemetryLoggerMiddleware.ts
3 participants
@joshgummersall @coveralls @stevengum