Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed unused dependency jsonpath #3331

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Feb 19, 2021

Description

The jsonpath package is no longer required and may cause security issues.

Specific Changes

  • Removed jsonpath from botbuilder-dialogs-adaptive
  • Removed jsonpath from botbuilder-dialogs-declarative

Testing

@boydc2014
Copy link
Contributor

@joshgummersall can we include this in R12, this is causing Composer's CI to fail because of security check.

@coveralls
Copy link

coveralls commented Feb 19, 2021

Pull Request Test Coverage Report for Build 580724785

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 84.853%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 4 60.47%
Totals Coverage Status
Change from base Build 580511849: -0.03%
Covered Lines: 18585
Relevant Lines: 20882

💛 - Coveralls

@joshgummersall joshgummersall merged commit 99f7bd2 into main Feb 19, 2021
@joshgummersall joshgummersall deleted the zim/remove-jsonpath branch February 19, 2021 16:01
@joshgummersall
Copy link
Contributor

@boydc2014 yep, we'll cut another RC today.

joshgummersall pushed a commit that referenced this pull request Feb 19, 2021
joshgummersall added a commit that referenced this pull request Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants