Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace execute with wsrun package #3317

Merged
merged 1 commit into from
Feb 16, 2021
Merged

fix: replace execute with wsrun package #3317

merged 1 commit into from
Feb 16, 2021

Conversation

joshgummersall
Copy link
Contributor

Simplifies codebase a bit by avoiding NIH.

@joshgummersall joshgummersall requested review from stevengum and a team as code owners February 16, 2021 20:36
@coveralls
Copy link

coveralls commented Feb 16, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 572794503

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 84.884%
Totals Coverage Status
Change from base Build 572557027: -0.009%
Covered Lines: 18556
Relevant Lines: 20846
💛 - Coveralls

stevengum
stevengum approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love avoiding NIH thanks for putting this PR together!

@stevengum stevengum merged commit 3770ddd into main Feb 16, 2021
@stevengum stevengum deleted the jpg/wsrun branch February 16, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshgummersall @coveralls @stevengum