Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: SendHandoffActivity action #3304

Merged
merged 9 commits into from
Mar 9, 2021
Merged

port: SendHandoffActivity action #3304

merged 9 commits into from
Mar 9, 2021

Conversation

joshgummersall
Copy link
Contributor

Fixes #3302

@joshgummersall
Copy link
Contributor Author

Note: draft to make sure this gets reviewed by someone very familiar with adaptive dialogs.

@coveralls
Copy link

coveralls commented Feb 12, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 634321803

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 84.844%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-dialogs-adaptive/src/conditions/onIntent.ts 2 87.5%
Totals Coverage Status
Change from base Build 634318134: -0.06%
Covered Lines: 18654
Relevant Lines: 20940
💛 - Coveralls

@joshgummersall joshgummersall marked this pull request as ready for review March 1, 2021 19:26
@joshgummersall joshgummersall requested review from chrimc62, stevengum, tomlm and a team as code owners March 1, 2021 19:26
@joshgummersall joshgummersall force-pushed the jpg/port-handoff-activity-action branch from c66975a to 254edf4 Compare March 2, 2021 17:42
@stevengum
Copy link
Member

stevengum commented Mar 2, 2021 •
edited
Loading

@chon219 can you review this PR when you have the time? Thanks!

Edit: Maybe that's not necessary since the PR is no longer in draft form, following @joshgummersall's comment. This PR LGTM :shipit:

@joshgummersall
Copy link
Contributor Author

@chon219 please do review. I removed the draft status as it's complete, but I would still like an extra set of adaptive eyes on it.

@chon219 chon219 merged commit 1c29775 into main Mar 9, 2021
@chon219 chon219 deleted the jpg/port-handoff-activity-action branch March 9, 2021 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chon219 chon219 chon219 left review comments

@stevengum stevengum stevengum approved these changes

@chrimc62 chrimc62 Awaiting requested review from chrimc62

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: Add SendHandoffActivity action (#5190)
4 participants
@joshgummersall @coveralls @stevengum @chon219