Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add --no-flat flag to browserify script in AEL #3292

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Conversation

stevengum
Copy link
Member

Fixes #3274

Description

In #3222, the tinyified adaptive-expressions browser.js was malformed and caused Composer to break. This PR fixes the break by disabling a plugin in tinyify.

Using ce99c67, the browserified-and-tinyified lib/browser.js is 1,091 KB in size and a 40 KB increase after #3222.

Specific Changes

  • add --no-flat flag to browserify script in AEL

Testing

  1. Cloned and setup BotFramework-Composer repo per README instructions
  2. Used yarn link to symlink a local clone of the JS repository
  3. Built JS repo @main (729a577)
  4. Ran yarn startall in BotFramework-Composer/Composer and observed bug
  5. Applied fix to adaptive-expressions package.json's "browserify" script
  6. Rebuilt adaptive-expressions and Composer
  7. Ran yarn startall in BotFramework-Composer/Composer
  8. Verified Composer started without bug

@stevengum stevengum added the Automation: No parity PR does not need to be applied to other languages. label Feb 9, 2021
@stevengum stevengum added this to the R12 milestone Feb 9, 2021
@coveralls
Copy link

coveralls commented Feb 9, 2021

Pull Request Test Coverage Report for Build 552627439

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 84.86%

Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/node.ts 2 95.26%
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 2 61.92%
Totals Coverage Status
Change from base Build 549312792: -0.03%
Covered Lines: 18552
Relevant Lines: 20846

💛 - Coveralls

@joshgummersall joshgummersall merged commit 8ae3ffd into main Feb 9, 2021
@joshgummersall joshgummersall deleted the stgum/3274 branch February 9, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The latest Adaptive-Expressions pakcage breaks Composer client
3 participants