Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: remove trust service url references #3285

Merged
merged 2 commits into from
Feb 8, 2021

Conversation

joshgummersall
Copy link
Contributor

Fixes #3259

@joshgummersall joshgummersall requested a review from a team as a code owner February 8, 2021 19:24
@joshgummersall joshgummersall force-pushed the jpg/remove-trust-service-url branch from da5ed7d to 96cc905 Compare February 8, 2021 19:27
@coveralls
Copy link

coveralls commented Feb 8, 2021

Pull Request Test Coverage Report for Build 549093157

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 45 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.01%) to 84.817%

Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 2 63.08%
libraries/botframework-connector/src/auth/appCredentials.ts 3 90.91%
libraries/botframework-connector/src/auth/jwtTokenValidation.ts 5 88.73%
libraries/botbuilder/src/botFrameworkAdapter.ts 35 88.94%
Totals Coverage Status
Change from base Build 549091919: 0.01%
Covered Lines: 18505
Relevant Lines: 20806

💛 - Coveralls

@joshgummersall joshgummersall force-pushed the jpg/remove-trust-service-url branch from 96cc905 to 43a763e Compare February 8, 2021 19:43
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@stevengum stevengum added this to the R12 milestone Feb 8, 2021
@stevengum stevengum merged commit cb80587 into main Feb 8, 2021
@stevengum stevengum deleted the jpg/remove-trust-service-url branch February 8, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: remove references to TrustServiceUrl (#5157)
3 participants