Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Mock QnAMaker via http request mocks #3278

Merged
merged 2 commits into from
Feb 7, 2021
Merged

feat: Mock QnAMaker via http request mocks #3278

merged 2 commits into from
Feb 7, 2021

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Feb 7, 2021

Fixes #3017

Description

Ported tests for QnAMakerDialog and QnAMakerRecognizer.

Specific Changes

  • Test QnAMakerDialog via http request mocks
  • Test QnAMakerRecognizer via http request mocks

Testing

@chon219 chon219 added the Area: AI-QnAMaker The issue is related to QnA Maker label Feb 7, 2021
@chon219 chon219 added this to the R12 milestone Feb 7, 2021
@chon219 chon219 requested review from a team as code owners February 7, 2021 08:01
@chon219 chon219 requested a review from Stevenic February 7, 2021 08:01
@coveralls
Copy link

coveralls commented Feb 7, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 544870090

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 84.884%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/node.ts 2 95.26%
Totals Coverage Status
Change from base Build 544483880: 0.2%
Covered Lines: 18253
Relevant Lines: 20525
💛 - Coveralls

@joshgummersall joshgummersall merged commit 427675b into main Feb 7, 2021
@joshgummersall joshgummersall deleted the zim/qnamaker-mock-test branch February 7, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

Assignees
No one assigned
Labels
Area: AI-QnAMaker The issue is related to QnA Maker
Projects
None yet
Milestone
R12
Development

Successfully merging this pull request may close these issues.

[PORT] mock qna recognizer and dialog like http request action
3 participants
@chon219 @coveralls @joshgummersall