Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated dialogManager to send EoC code like dialogHelper #3270

Merged
merged 2 commits into from
Feb 5, 2021
Merged

Updated dialogManager to send EoC code like dialogHelper #3270

merged 2 commits into from
Feb 5, 2021

Conversation

gabog
Copy link
Contributor

@gabog gabog commented Feb 4, 2021

Fixes #3269

also added check to the related test

@gabog gabog requested review from a team as code owners February 4, 2021 22:00
@gabog gabog requested review from tomlm and luhan2017 February 4, 2021 22:00
@coveralls
Copy link

coveralls commented Feb 4, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 538818544

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.04%) to 84.664%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 2 61.63%
libraries/botbuilder-dialogs/src/dialogManager.ts 6 92.31%
Totals Coverage Status
Change from base Build 535919117: 0.04%
Covered Lines: 18211
Relevant Lines: 20519
💛 - Coveralls

@stevengum stevengum merged commit 9e39b29 into main Feb 5, 2021
@stevengum stevengum deleted the gabog/FixDialogManagerToReturnEoCCode branch February 5, 2021 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@tomlm tomlm Awaiting requested review from tomlm

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DialogManager does not return EoC code when a dialog ends (JS)
3 participants
@gabog @coveralls @stevengum