Change the implementation in string a number in the string pre-built function #3249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the string pre-built function does not always work correctly for numeric inputs.
for example:
string(1.22, 'de-DE')
returns1.22
. It is not the same as the result of C#.So I switched the toLocaleString() to d3-format in the string function while a numeric input passed.
With the change, now
string(1.22, 'de-DE')
will return:1,22