Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix createHandoffEvent activity.type & cleanup #3243

Merged
merged 1 commit into from
Jan 29, 2021
Merged

fix createHandoffEvent activity.type & cleanup #3243

merged 1 commit into from
Jan 29, 2021

Conversation

stevengum
Copy link
Member

Fixes #3242

Description

Sets the type on the returned Activity to ActivityTypes.Event in EventFactory.createHandoffEvent()

Specific Changes

  • Set returned Activity.type to ActivityTypes.Event
  • Cleanup imports, remove unnecessary cast
  • Add test coverage

Testing

Updated existing test with coverage for changes.

@stevengum stevengum requested a review from a team as a code owner January 29, 2021 21:32
@coveralls
Copy link

coveralls commented Jan 29, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 522055734

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 84.745%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/node.ts 2 95.26%
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 2 61.63%
Totals Coverage Status
Change from base Build 522011158: -0.03%
Covered Lines: 18188
Relevant Lines: 20491
💛 - Coveralls

@stevengum stevengum merged commit 9e6fdf8 into main Jan 29, 2021
@stevengum stevengum deleted the stgum/3242 branch January 29, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EventFactory.createHandoffInitiation does not set the Activity.type to "event"
3 participants
@stevengum @coveralls @joshgummersall