Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: port Luis intent2 properties from dotnet #3234

Merged
merged 2 commits into from
Jan 29, 2021
Merged

fix: port Luis intent2 properties from dotnet #3234

merged 2 commits into from
Jan 29, 2021

Conversation

joshgummersall
Copy link
Contributor

Fixes #2398

@joshgummersall joshgummersall requested review from a team as code owners January 27, 2021 21:27
@joshgummersall joshgummersall force-pushed the jpg/port-luis-intent2-properties branch from 3049778 to 802b9aa Compare January 27, 2021 21:27
@coveralls
Copy link

coveralls commented Jan 27, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 521827505

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 84.771%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-ai/src/luisAdaptiveRecognizer.ts 4 84.96%
libraries/botbuilder-ai/src/luisRecognizer.ts 5 94.62%
Totals Coverage Status
Change from base Build 521766937: 0.01%
Covered Lines: 18192
Relevant Lines: 20491
💛 - Coveralls

@joshgummersall joshgummersall added this to the R12 milestone Jan 29, 2021
@joshgummersall joshgummersall force-pushed the jpg/port-luis-intent2-properties branch from 802b9aa to 2a4880f Compare January 29, 2021 19:39
@stevengum stevengum merged commit de9a970 into main Jan 29, 2021
@stevengum stevengum deleted the jpg/port-luis-intent2-properties branch January 29, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
R12
Development

Successfully merging this pull request may close these issues.

Port missing LuisTelemetryConstants for 'topTwoIntents' from C#
3 participants
@joshgummersall @coveralls @stevengum