Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update access modifiers in QnAMakerDialog #3230

Merged
merged 17 commits into from
Feb 1, 2021
Merged

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Jan 27, 2021

Fixes #3214

Description

Some methods and properties in QnAMakerDialog are incorrect and not aligned with the implementation in C#.

Specific Changes

  • Updated access modifiers for methods and properties in QnAMakerDialog
  • Removed strictFiltersJoinOperator in QnAMaker and QnAMakerDialog to align with C# design
  • Added missing logPersonalInformation property to QnAMakerRecognizer

Testing

Updated tests to reflect changes.

@chon219 chon219 added the Area: AI-QnAMaker The issue is related to QnA Maker label Jan 27, 2021
@chon219 chon219 requested review from a team as code owners January 27, 2021 09:57
Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple quick suggestions.

@chon219 chon219 requested a review from a team as a code owner January 28, 2021 05:40
@coveralls
Copy link

coveralls commented Jan 29, 2021

Pull Request Test Coverage Report for Build 522289347

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 68 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 84.675%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-ai/src/qnaMaker.ts 1 96.15%
libraries/botbuilder-ai/src/qnaMakerRecognizer.ts 8 78.09%
libraries/botbuilder-ai/src/qnaMakerDialog.ts 59 56.47%
Totals Coverage Status
Change from base Build 522086506: -0.1%
Covered Lines: 18196
Relevant Lines: 20501

💛 - Coveralls

@joshgummersall joshgummersall added this to the R12 milestone Jan 29, 2021
@joshgummersall
Copy link
Contributor

@stevengum I merged in main and resolved conflicts/lint errors.

@chon219 chon219 merged commit 6c740ce into main Feb 1, 2021
@chon219 chon219 deleted the zim/qna-maker-improvement branch February 1, 2021 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: AI-QnAMaker The issue is related to QnA Maker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adaptive card rendering issue from qna maker
4 participants