Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: botbuilder-ai eslint warnings and errors #3225

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Conversation

joshgummersall
Copy link
Contributor

Title says it all - finally removed warn-only for a package!

@joshgummersall joshgummersall requested review from a team as code owners January 27, 2021 00:28
"no-unused-vars": "off",
"no-var": "error",
"prettier/prettier": "error"
"prettier/prettier": "error",
"security/detect-object-injection": "off"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to be argued with on this, I don't think it provides us a lot of value.

@coveralls
Copy link

coveralls commented Jan 27, 2021

Pull Request Test Coverage Report for Build 521721127

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 86 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.001%) to 84.744%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-ai/src/luisRecognizerOptions.ts 1 81.82%
libraries/botbuilder-ai/src/qnaMakerRecognizer.ts 1 82.5%
libraries/botbuilder-ai/src/qnamaker-utils/generateAnswerUtils.ts 1 89.06%
libraries/botbuilder-ai/src/qnamaker-utils/trainUtils.ts 1 88.89%
libraries/botbuilder-ai/src/luisRecognizerOptionsV2.ts 2 95.65%
libraries/botbuilder-ai/src/qnamaker-utils/activeLearningUtils.ts 3 78.38%
libraries/botbuilder-ai/src/qnamaker-utils/httpRequestUtils.ts 3 81.25%
libraries/botbuilder-ai/src/luisAdaptiveRecognizer.ts 4 83.13%
libraries/botbuilder-ai/src/luisRecognizerOptionsV3.ts 5 91.28%
libraries/botbuilder-ai/src/luisRecognizer.ts 5 93.41%
Totals Coverage Status
Change from base Build 521714205: -0.001%
Covered Lines: 18185
Relevant Lines: 20484

💛 - Coveralls

@joshgummersall joshgummersall force-pushed the jpg/botbuilder-ai-eslint branch from fd54a04 to bdd5bb8 Compare January 27, 2021 23:02
@joshgummersall joshgummersall force-pushed the jpg/botbuilder-ai-eslint branch from bdd5bb8 to de12a32 Compare January 28, 2021 19:46
@joshgummersall joshgummersall linked an issue Jan 28, 2021 that may be closed by this pull request
@joshgummersall joshgummersall added this to the R12 milestone Jan 29, 2021
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@stevengum stevengum merged commit 16734d5 into main Jan 29, 2021
@stevengum stevengum deleted the jpg/botbuilder-ai-eslint branch January 29, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tune security eslint warnings
3 participants