fix: exec cmd cleanup, simplification, colors #3217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgummersall
force-pushed
the
jpg/repo-utils-fixes
branch
2 times, most recently
from
000816b to
a2803fb
Compare
Pull Request Test Coverage Report for Build 509993601
💛 - Coveralls |
joshgummersall
force-pushed
the
jpg/repo-utils-fixes
branch
from
a2803fb to
6e72e70
Compare
joshgummersall
force-pushed
the
jpg/repo-utils-fixes
branch
from
6e72e70 to
72e034f
Compare
joshgummersall
commented
Jan 25, 2021
| workspaces: Workspace[], | ||
| task: (workspace: Workspace) => Promise<boolean>, | ||
| concurrency: number | ||
| ) => Promise<boolean>; |
There was a problem hiding this comment.
This is one of the main changes - execution now returns a boolean to indicate success. This is used to support continuing to execute tasks if one fails while still exiting with a non-zero status code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the
execCmd.tshelper a bit and adds some colorful output.