Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: http request mock #3201

Merged
merged 9 commits into from
Jan 25, 2021
Merged

feat: http request mock #3201

merged 9 commits into from
Jan 25, 2021

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Jan 19, 2021

Fixes #2391

Description

Added HttpRequestMock

Specific Changes

Testing

@chon219 chon219 added the Area: Testing framework Issues related to the bot testing framework label Jan 19, 2021
@chon219 chon219 added this to the R12 milestone Jan 19, 2021
joshgummersall
joshgummersall reviewed Jan 19, 2021
View reviewed changes
Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks slick! Glad nock was a suitable backend for this.

@coveralls
Copy link

coveralls commented Jan 20, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 508787431

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 84.704%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/nodeWebSocketClient.ts 1 68.75%
libraries/botbuilder-dialogs-adaptive-testing/src/testScript.ts 2 92.41%
Totals Coverage Status
Change from base Build 502953678: 0.1%
Covered Lines: 18068
Relevant Lines: 20364
💛 - Coveralls

joshgummersall
joshgummersall approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick question, otherwise LGTM!

@chon219 chon219 marked this pull request as ready for review January 25, 2021 08:14
@chon219 chon219 requested review from stevengum and a team as code owners January 25, 2021 08:14
@chon219 chon219 requested a review from luhan2017 January 25, 2021 08:14
@chon219 chon219 merged commit e5a4fc6 into main Jan 25, 2021
@chon219 chon219 deleted the zim/http-request-mock branch January 25, 2021 08:20
@chon219
Copy link
Member Author

chon219 commented Jan 25, 2021

forgot to add inline docs, I will send out another PR later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@stevengum stevengum Awaiting requested review from stevengum

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees
No one assigned
Labels
Area: Testing framework Issues related to the bot testing framework
Projects
None yet
Milestone
R12
Development

Successfully merging this pull request may close these issues.

[PORT] add HttpRequestMock
3 participants
@chon219 @coveralls @joshgummersall