Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make bigInt more applicability in adaptive-expressions #3197

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Conversation

Danieladu
Copy link
Contributor

Fixes #2211
Currently, JS sdk uses Number to handler all number input, and with BigInt to handler ticks().
Here SDK provides such a solution to reduce the gap between these two languages:

  • Keep the range gap of the normal number.-2^63 ~ 2^63 -1 for C# and -2^53+1 ~ 2^53 for JS. (JS would provide inaccurate calculation of numbers beyond this range)
  • Provide a solution to convert bigint object into a normal number in js. int() function can accept a bigint input, and output a fuzzy number output.
    For example: int(ticks(utcNow())) - 1 would be valid and the output would be a number. But the accuracy of the output is not guaranteed

@Danieladu Danieladu requested review from a team as code owners January 18, 2021 03:50
@Danieladu Danieladu requested review from Stevenic and tomlm January 18, 2021 03:50
@coveralls
Copy link

coveralls commented Jan 18, 2021

Pull Request Test Coverage Report for Build 497494041

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 84.5%

Totals Coverage Status
Change from base Build 497493701: 0.003%
Covered Lines: 17819
Relevant Lines: 20147

💛 - Coveralls

@Danieladu Danieladu merged commit b249e8c into main Jan 20, 2021
@Danieladu Danieladu deleted the hond/bigint branch January 20, 2021 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Expression] Handler big number correctly
3 participants