Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: null/undefined is not an object #3190

Merged
merged 1 commit into from
Jan 15, 2021
Merged

fix: null/undefined is not an object #3190

merged 1 commit into from
Jan 15, 2021

Conversation

joshgummersall
Copy link
Contributor

Small issue with typeof null === 'object' is true.

@joshgummersall joshgummersall requested a review from a team as a code owner January 14, 2021 22:56
@coveralls
Copy link

coveralls commented Jan 14, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 486666605

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 84.492%
Totals Coverage Status
Change from base Build 486664818: -0.006%
Covered Lines: 17814
Relevant Lines: 20142
💛 - Coveralls

@stevengum stevengum merged commit 16d34c4 into main Jan 15, 2021
@stevengum stevengum deleted the jpg/fix-object-test branch January 15, 2021 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshgummersall @coveralls @stevengum