Ensure UserActivity activities inherit from set activity #3187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
userActivity
in the Node SDK didn't match the one in the .NET SDK, with respect to usingactivity.from
in theactivity
property supplied intest.dialog
files.Specific Changes
else if
condition to match .NET SDK, that setsactivity.from
to match theactivity.from
if passed in from thetest.dialog
file.Testing
Added a test for
UserActivity
that would catch this as well as other things, since the test didn't exist.The first
Microsoft.Test.UserActivity
is to check that it sets the adapter defaults. The next activity is to check that from gets set by theactivity.from
property. The next is to make sure it gets set by theuser
property