Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure UserActivity activities inherit from set activity #3187

Merged
merged 3 commits into from
Jan 14, 2021

Conversation

mdrichardson
Copy link
Contributor

@mdrichardson mdrichardson commented Jan 14, 2021

Description

userActivity in the Node SDK didn't match the one in the .NET SDK, with respect to using activity.from in the activity property supplied in test.dialog files.

Specific Changes

  • Added an else if condition to match .NET SDK, that sets activity.from to match the activity.from if passed in from the test.dialog file.

Testing

Added a test for UserActivity that would catch this as well as other things, since the test didn't exist.

The first Microsoft.Test.UserActivity is to check that it sets the adapter defaults. The next activity is to check that from gets set by the activity.from property. The next is to make sure it gets set by the user property

@coveralls
Copy link

coveralls commented Jan 14, 2021

Pull Request Test Coverage Report for Build 486587133

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.005%) to 84.475%

Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 2 61.63%
libraries/botbuilder-dialogs-adaptive-testing/src/testActions/userActivity.ts 2 85.71%
Totals Coverage Status
Change from base Build 481448147: -0.005%
Covered Lines: 17812
Relevant Lines: 20142

💛 - Coveralls

@mdrichardson mdrichardson changed the title fix MemoryAssertions Ensure UserActivity activities inherit from set activity Jan 14, 2021
@joshgummersall joshgummersall merged commit f739ef0 into microsoft:main Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants