Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle add-upgrade and remove-upgrade InstallationUpdate activities #3178

Merged
merged 4 commits into from
Jan 12, 2021
Merged

Handle add-upgrade and remove-upgrade InstallationUpdate activities #3178

merged 4 commits into from
Jan 12, 2021

Conversation

mdrichardson
Copy link
Contributor

Fixes #3174

Description

Adds add-upgrade and remove-upgrade handling to Teams InstallationUpdate activity handlers.

@mdrichardson mdrichardson requested a review from a team as a code owner January 8, 2021 18:24
@coveralls
Copy link

coveralls commented Jan 8, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 480939515

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 84.366%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-core/src/activityHandler.ts 1 93.8%
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 2 61.63%
libraries/botbuilder-core/src/activityHandlerBase.ts 6 87.04%
Totals Coverage Status
Change from base Build 480938929: -0.02%
Covered Lines: 17745
Relevant Lines: 20091
💛 - Coveralls

@joshgummersall joshgummersall merged commit 2525310 into microsoft:main Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@EricDahlvang EricDahlvang Awaiting requested review from EricDahlvang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for new installation action types (JS)
4 participants
@mdrichardson @coveralls @joshgummersall @stevengum