Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: DialogInspector and new test actions #3168

Merged
merged 8 commits into from
Jan 7, 2021
Merged

feat: DialogInspector and new test actions #3168

merged 8 commits into from
Jan 7, 2021

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Dec 31, 2020 •
edited
Loading

Fixes #3113
Fixes #3035
Fixes #2474

Description

Implemented DialogInspector with some new test actions.

Specific Changes

  • Implemented DialogInspector
  • Added AssertNoReply
  • Added MemoryAssertions
  • Added SetProperties (Microsoft.Test.SetProperties)
  • Centralized resetting retries

Testing

Added test PropertyMock.

@chon219 chon219 added this to the R12 milestone Dec 31, 2020
@chon219
Copy link
Member Author

chon219 commented Dec 31, 2020

#3113 should be fixed in this PR as well.

@chon219 chon219 added Area: Testing framework Issues related to the bot testing framework Area: Adaptive The issue is related to Adaptive dialogs labels Dec 31, 2020
@coveralls
Copy link

coveralls commented Dec 31, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 467705414

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 177 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.08%) to 84.353%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-dialogs-adaptive-testing/src/testActions/customEvent.ts 1 84.62%
libraries/botbuilder-dialogs-adaptive-testing/src/testActions/userSays.ts 1 89.47%
libraries/botbuilder-dialogs-adaptive-testing/src/testScript.ts 1 93.15%
libraries/botbuilder-dialogs-adaptive-testing/src/testActions/assertReplyActivity.ts 2 80.0%
libraries/botbuilder-dialogs-adaptive-testing/src/testActions/userTyping.ts 3 69.23%
libraries/botbuilder-dialogs-adaptive-testing/src/testActions/userActivity.ts 4 69.23%
libraries/botbuilder-dialogs-adaptive/src/adaptiveDialog.ts 165 38.52%
Totals Coverage Status
Change from base Build 462134831: -0.08%
Covered Lines: 17732
Relevant Lines: 20078
💛 - Coveralls

@chon219 chon219 requested a review from joshgummersall January 4, 2021 06:05
@chon219 chon219 marked this pull request as ready for review January 4, 2021 06:05
@chon219 chon219 requested review from a team as code owners January 4, 2021 06:05
@chon219 chon219 requested a review from Stevenic January 4, 2021 06:05
@chon219 chon219 merged commit 28eb35d into main Jan 7, 2021
@chon219 chon219 deleted the zim/adaptive-test-actions branch January 7, 2021 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

Assignees
No one assigned
Labels
Area: Adaptive The issue is related to Adaptive dialogs Area: Testing framework Issues related to the bot testing framework
Projects
None yet
Milestone
R12
3 participants
@chon219 @coveralls @joshgummersall