Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tests for BeginSkill with middlewares #3167

Merged
merged 2 commits into from
Jan 4, 2021
Merged

fix: tests for BeginSkill with middlewares #3167

merged 2 commits into from
Jan 4, 2021

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Dec 31, 2020

Fixes #3037
Fixes #3042

Description

adds two BeginSkill action tests using .dialog files and required middleware

Specific Changes

  • Registered Microsoft.StaticActivityTemplate
  • Registered Microsoft.ActivityTemplate
  • Registered Microsoft.TextTemplate
  • Added tests for BeginSkill with middlewares

Testing

Added tests.

@chon219 chon219 added the Area: Adaptive The issue is related to Adaptive dialogs label Dec 31, 2020
@chon219 chon219 added this to the R12 milestone Dec 31, 2020
@chon219 chon219 requested review from a team as code owners December 31, 2020 05:45
@chon219 chon219 requested a review from Stevenic December 31, 2020 05:45
@coveralls
Copy link

coveralls commented Dec 31, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 453997102

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 28 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.09%) to 84.434%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
libraries/botbuilder-dialogs-adaptive/src/templates/staticActivityTemplate.ts 3 70.0%
libraries/botbuilder-dialogs-adaptive/src/templates/activityTemplate.ts 4 83.33%
libraries/botbuilder-dialogs-adaptive/src/templates/textTemplate.ts 4 79.17%
libraries/botbuilder-dialogs-adaptive/src/input/inputDialog.ts 16 82.98%
Totals Coverage Status
Change from base Build 453756477: 0.09%
Covered Lines: 17652
Relevant Lines: 19979
💛 - Coveralls

@chon219 chon219 merged commit f079830 into main Jan 4, 2021
@chon219 chon219 deleted the zim/begin-skill-tests branch January 4, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

Assignees
No one assigned
Labels
Area: Adaptive The issue is related to Adaptive dialogs
Projects
None yet
Milestone
R12
Development

Successfully merging this pull request may close these issues.

[PORT] Enable middleware in TestScript and refactor BeginSkill tests [PORT] Write unit tests for BeginSkill
3 participants
@chon219 @coveralls @joshgummersall