Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use package 'uuid' to generate RFC-compliant UUIDs #3166

Merged
merged 1 commit into from
Dec 31, 2020
Merged

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Dec 30, 2020

Fixes #3160

Description

Using package uuid to generate RFC-compliant UUIDs

Specific Changes

  • Added uuid package to adaptive-expressions
  • Added uuid package to botbuilder-ai-orchestrator
  • Added uuid package to botbuilder-core
  • Added uuid package to botbuilder
  • Added uuid package to botbuilder-lg
  • Added uuid package to botbuilder-dialogs
  • Updated uuid package to 8.x in botframework-config
  • Updated uuid package to 8.x in botframework-streaming

Testing

Fixed tests.

@chon219 chon219 added this to the R12 milestone Dec 30, 2020
@chon219 chon219 requested review from a team as code owners December 30, 2020 07:31
@coveralls
Copy link

coveralls commented Dec 30, 2020

Pull Request Test Coverage Report for Build 452240968

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 65 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.1%) to 84.274%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder/src/inspectionMiddleware.ts 1 95.77%
libraries/botbuilder/src/streaming/tokenResolver.ts 2 88.0%
libraries/botbuilder/src/skills/skillHandler.ts 3 89.19%
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 4 60.76%
libraries/botbuilder-lg/src/templateExtensions.ts 5 84.48%
libraries/botbuilder-lg/src/templates.ts 5 93.23%
libraries/adaptive-expressions/src/triggerTrees/node.ts 10 90.51%
libraries/botbuilder-core/src/testAdapter.ts 16 89.11%
libraries/botbuilder-ai-orchestrator/src/orchestratorAdaptiveRecognizer.ts 19 61.65%
Totals Coverage Status
Change from base Build 451215210: -0.1%
Covered Lines: 17610
Relevant Lines: 19961

💛 - Coveralls

Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for taking care of this 😄

@chon219 chon219 merged commit c05c59a into main Dec 31, 2020
@chon219 chon219 deleted the zim/uuid branch December 31, 2020 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add uuid function to botbuilder-stdlib
3 participants